diff --git a/nw/gui/build.py b/nw/gui/build.py index eb7a88e3..aea1f237 100644 --- a/nw/gui/build.py +++ b/nw/gui/build.py @@ -762,12 +762,10 @@ class GuiBuildNovel(QDialog): if self.mainConf.showGUI: dlgOpt = QFileDialog.Options() dlgOpt |= QFileDialog.DontUseNativeDialog - saveTo = QFileDialog.getSaveFileName( + savePath, _ = QFileDialog.getSaveFileName( self, "Save Document As", savePath, options=dlgOpt ) - if saveTo[0]: - savePath = saveTo[0] - else: + if not savePath: return False self.mainConf.setLastPath(savePath) diff --git a/nw/gui/writingstats.py b/nw/gui/writingstats.py index f748f95e..1d634ec6 100644 --- a/nw/gui/writingstats.py +++ b/nw/gui/writingstats.py @@ -334,12 +334,11 @@ class GuiWritingStats(QDialog): dlgOpt = QFileDialog.Options() dlgOpt |= QFileDialog.DontUseNativeDialog - saveTo = QFileDialog.getSaveFileName( + savePath, _ = QFileDialog.getSaveFileName( self, "Save Document As", savePath, options=dlgOpt ) - if saveTo[0]: - savePath = saveTo[0] - else: + + if not savePath: return False self.mainConf.setLastPath(savePath) diff --git a/nw/guimain.py b/nw/guimain.py index 0cdef1ef..076eccf0 100644 --- a/nw/guimain.py +++ b/nw/guimain.py @@ -562,12 +562,10 @@ class GuiMain(QMainWindow): ] dlgOpt = QFileDialog.Options() dlgOpt |= QFileDialog.DontUseNativeDialog - inPath = QFileDialog.getOpenFileName( + loadFile, _ = QFileDialog.getOpenFileName( self, "Import File", lastPath, options=dlgOpt, filter=";;".join(extFilter) ) - if inPath: - loadFile = inPath[0] - else: + if not loadFile: return False if loadFile.strip() == "": diff --git a/tests/test_dialogs.py b/tests/test_dialogs.py index 6fe0f2e4..9d05f56f 100644 --- a/tests/test_dialogs.py +++ b/tests/test_dialogs.py @@ -283,10 +283,10 @@ def testWritingStatsExport(qtbot, monkeypatch, yesToAll, nwFuncTemp, nwTemp): assert isinstance(sessLog, GuiWritingStats) qtbot.wait(stepDelay) - monkeypatch.setattr(QFileDialog, "getSaveFileName", lambda *args, **kwargs: []) + monkeypatch.setattr(QFileDialog, "getSaveFileName", lambda *args, **kwargs: ("", "")) assert not sessLog._saveData(sessLog.FMT_CSV) - monkeypatch.setattr(QFileDialog, "getSaveFileName", lambda ss, tt, pp, options: [pp]) + monkeypatch.setattr(QFileDialog, "getSaveFileName", lambda ss, tt, pp, options: (pp, "")) assert sessLog._saveData(sessLog.FMT_CSV) qtbot.wait(stepDelay) assert sessLog._saveData(sessLog.FMT_JSON) diff --git a/tests/test_gui.py b/tests/test_gui.py index 8cfb043d..0b32327e 100644 --- a/tests/test_gui.py +++ b/tests/test_gui.py @@ -1107,16 +1107,16 @@ def testInsertMenu(qtbot, monkeypatch, nwFuncTemp, nwTemp): nwGUI.closeDocument() # First, with no path - monkeypatch.setattr(QFileDialog, "getOpenFileName", lambda *args, **kwards: []) + monkeypatch.setattr(QFileDialog, "getOpenFileName", lambda *args, **kwards: ("", "")) assert not nwGUI.importDocument() # Then with a path, but an invalid one - monkeypatch.setattr(QFileDialog, "getOpenFileName", lambda *args, **kwards: [" "]) + monkeypatch.setattr(QFileDialog, "getOpenFileName", lambda *args, **kwards: (" ", "")) assert not nwGUI.importDocument() # Then a valid path, but bot a file that exists theFile = os.path.join(nwTemp, "import.txt") - monkeypatch.setattr(QFileDialog, "getOpenFileName", lambda *args, **kwards: [theFile]) + monkeypatch.setattr(QFileDialog, "getOpenFileName", lambda *args, **kwards: (theFile, "")) assert not nwGUI.importDocument() # Create the file and try again, but with no target document open