From cff7463a7c83b5430a5ba8b6347fbc571587c703 Mon Sep 17 00:00:00 2001 From: "Veronica K. B. Olsen" <1619840+vkbo@users.noreply.github.com> Date: Thu, 20 Aug 2020 20:43:19 +0200 Subject: [PATCH] Make sure the correct item is selected --- nw/gui/projsettings.py | 2 +- tests/test_gui.py | 12 ++++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/nw/gui/projsettings.py b/nw/gui/projsettings.py index 52d82809..066c618f 100644 --- a/nw/gui/projsettings.py +++ b/nw/gui/projsettings.py @@ -617,7 +617,7 @@ class GuiProjectEditReplace(QWidget): saveKey = "" % (self.listBox.topLevelItemCount() + 1) newVal = "" newItem = QTreeWidgetItem([saveKey, newVal]) - self.listBox.insertTopLevelItem(0, newItem) + self.listBox.addTopLevelItem(newItem) return True def _delEntry(self): diff --git a/tests/test_gui.py b/tests/test_gui.py index 4b0d1107..1f553a8c 100644 --- a/tests/test_gui.py +++ b/tests/test_gui.py @@ -337,7 +337,15 @@ def testProjectEditor(qtbot, nwTempGUI, nwRef, nwTemp): qtbot.wait(stepDelay) projEdit.tabReplace.listBox.clearSelection() qtbot.mouseClick(projEdit.tabReplace.addButton, Qt.LeftButton) - projEdit.tabReplace.listBox.topLevelItem(0).setSelected(True) + + newIdx = -1 + for i in range(projEdit.tabReplace.listBox.topLevelItemCount()): + if projEdit.tabReplace.listBox.topLevelItem(0).text(0) == "": + newIdx = i + break + + assert newIdx >= 0 + projEdit.tabReplace.listBox.topLevelItem(newIdx).setSelected(True) for c in "Delete": qtbot.keyClick(projEdit.tabReplace.editKey, c, delay=keyDelay) for c in "This Stuff": @@ -346,7 +354,7 @@ def testProjectEditor(qtbot, nwTempGUI, nwRef, nwTemp): qtbot.wait(stepDelay) projEdit.tabReplace.listBox.clearSelection() - projEdit.tabReplace.listBox.topLevelItem(0).setSelected(True) + projEdit.tabReplace.listBox.topLevelItem(newIdx).setSelected(True) qtbot.mouseClick(projEdit.tabReplace.delButton, Qt.LeftButton) qtbot.wait(stepDelay)