Use selected text for project search (#1790)

novelwriter/core/coretools.py

@@ -382,8 +382,7 @@ class DocSearch:
                         escaped += f"\\{c}"
                 search = escaped
         if self._words:
-            search = search if search.startswith("\\b") else f"\\b{search}"
+            search = f"(?:^|\\b){search}(?:$|\\b)"
-            search = search if search.endswith("\\b") else f"{search}\\b"
         return search
 
 # END Class DocSearch

novelwriter/gui/doceditor.py

@@ -596,6 +596,15 @@ class GuiDocEditor(QPlainTextEdit):
         text = text.replace(nwUnicode.U_PSEP, "\n")  # Paragraph separators
         return text
 
+    def getSelectedText(self) -> str:
+        """Get currently selected text."""
+        if (cursor := self.textCursor()).hasSelection():
+            text = cursor.selectedText()
+            text = text.replace(nwUnicode.U_LSEP, "\n")  # Line separators
+            text = text.replace(nwUnicode.U_PSEP, "\n")  # Paragraph separators
+            return text
+        return ""
+
     def getCursorPosition(self) -> int:
         """Find the cursor position in the document. If the editor has a
         selection, return the position of the end of the selection.
@@ -642,12 +651,13 @@ class GuiDocEditor(QPlainTextEdit):
                 logger.debug("Cursor moved to line %d", line)
         return
 
-    def setCursorSelection(self, selStart: int, selLength: int) -> None:
+    def setCursorSelection(self, start: int, length: int) -> None:
         """Make a text selection."""
-        cursor = self.textCursor()
+        if start >= 0 and length > 0:
-        cursor.setPosition(selStart, QTextCursor.MoveMode.MoveAnchor)
+            cursor = self.textCursor()
-        cursor.setPosition(selStart + selLength, QTextCursor.MoveMode.KeepAnchor)
+            cursor.setPosition(start, QTextCursor.MoveMode.MoveAnchor)
-        self.setTextCursor(cursor)
+            cursor.setPosition(start + length, QTextCursor.MoveMode.KeepAnchor)
+            self.setTextCursor(cursor)
         return
 
     ##
@@ -1280,11 +1290,7 @@ class GuiDocEditor(QPlainTextEdit):
 
     def beginSearch(self) -> None:
         """Set the selected text as the search text."""
-        cursor = self.textCursor()
+        self.docSearch.setSearchText(self.getSelectedText() or None)
-        if cursor.hasSelection():
-            self.docSearch.setSearchText(cursor.selectedText())
-        else:
-            self.docSearch.setSearchText(None)
         resS, _ = self.findAllOccurences()
         self.docSearch.setResultCount(None, len(resS))
         return
@@ -2226,7 +2232,7 @@ class BackgroundWordCounter(QRunnable):
         """
         self._isRunning = True
         if self._forSelection:
-            text = self._docEditor.textCursor().selectedText()
+            text = self._docEditor.getSelectedText()
         else:
             text = self._docEditor.getText()
 

novelwriter/gui/search.py

@@ -192,10 +192,13 @@ class GuiProjectSearch(QWidget):
             )
         return
 
-    def beginSearch(self) -> None:
+    def beginSearch(self, text: str = "") -> None:
         """Focus the search box and select its text, if any."""
         self.searchText.setFocus()
         self.searchText.selectAll()
+        if text:
+            self.searchText.setText(text.partition("\n")[0])
+            self.searchText.selectAll()
         return
 
     def closeProjectTasks(self) -> None:

novelwriter/guimain.py

@@ -1168,7 +1168,9 @@ class GuiMain(QMainWindow):
         elif view == nwView.SEARCH:
             self.mainStack.setCurrentWidget(self.splitMain)
             self.projStack.setCurrentWidget(self.projSearch)
-            self.projSearch.beginSearch()
+            self.projSearch.beginSearch(
+                self.docEditor.getSelectedText() if self.docEditor.anyFocus() else ""
+            )
         elif view == nwView.OUTLINE:
             self.mainStack.setCurrentWidget(self.outlineView)
         return

tests/test_core/test_core_coretools.py

@@ -439,10 +439,7 @@ def testCoreTools_DocSearch(monkeypatch, mockGUI, fncPath, mockRnd, ipsumText):
     # Whole Words
     search.setWholeWords(True)
     search.setUserRegEx(True)
-    assert search._buildPattern("Hi") == r"\bHi\b"
+    assert search._buildPattern("Hi") == r"(?:^|\b)Hi(?:$|\b)"
-    assert search._buildPattern(r"\bHi") == r"\bHi\b"
-    assert search._buildPattern(r"Hi\b") == r"\bHi\b"
-    assert search._buildPattern(r"\bHi\b") == r"\bHi\b"
     search.setWholeWords(False)
     search.setUserRegEx(False)
 

tests/test_gui/test_gui_search.py

@@ -117,7 +117,7 @@ def testGuiDocSearch_Main(qtbot, monkeypatch, nwGUI, prjLipsum):
 
     # RegEx
     search.toggleRegEx.setChecked(True)
-    search.searchText.setText("(dolor|dolorem)")
+    search.beginSearch("(dolor|dolorem)")
     search.searchAction.activate(QAction.ActionEvent.Trigger)
     assert search.searchResult.topLevelItemCount() == 10
     assert totalCount() == 34