From aceb344856ae76a264a30ca1027afd03bb1dc153 Mon Sep 17 00:00:00 2001 From: Veronica Berglyd Olsen <1619840+vkbo@users.noreply.github.com> Date: Sat, 25 May 2024 22:43:09 +0200 Subject: [PATCH] Fix a potential segfault issue in main gui and add auto-build on open manuscript tool --- novelwriter/guimain.py | 6 ++---- novelwriter/tools/manuscript.py | 5 +++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/novelwriter/guimain.py b/novelwriter/guimain.py index af9ad75f..eb9b4eda 100644 --- a/novelwriter/guimain.py +++ b/novelwriter/guimain.py @@ -800,8 +800,7 @@ class GuiMain(QMainWindow): def showBuildManuscriptDialog(self) -> None: """Open the build manuscript dialog.""" if SHARED.hasProject: - if (dialog := SHARED.findTopLevelWidget(GuiManuscript)) is None: - dialog = GuiManuscript(self) + dialog = GuiManuscript(self) dialog.activateDialog() dialog.loadContent() return @@ -819,8 +818,7 @@ class GuiMain(QMainWindow): def showWritingStatsDialog(self) -> None: """Open the session stats dialog.""" if SHARED.hasProject: - if (dialog := SHARED.findTopLevelWidget(GuiWritingStats)) is None: - dialog = GuiWritingStats(self) + dialog = GuiWritingStats(self) dialog.activateDialog() dialog.populateGUI() return diff --git a/novelwriter/tools/manuscript.py b/novelwriter/tools/manuscript.py index 263bf332..841eaa15 100644 --- a/novelwriter/tools/manuscript.py +++ b/novelwriter/tools/manuscript.py @@ -246,6 +246,7 @@ class GuiManuscript(NToolDialog): self._updateBuildsList() if selected in self._buildMap: self.buildList.setCurrentItem(self._buildMap[selected]) + QTimer.singleShot(200, self._generatePreview) return @@ -363,8 +364,8 @@ class GuiManuscript(NToolDialog): def _buildManuscript(self) -> None: """Open the build dialog and build the manuscript.""" if build := self._getSelectedBuild(): - dlgBuild = GuiManuscriptBuild(self, build) - dlgBuild.exec() + dialog = GuiManuscriptBuild(self, build) + dialog.exec() # After the build is done, save build settings changes if build.changed: