Add a bunch of None checks, even if many may be redundant

novelwriter/dialogs/docmerge.py

@@ -117,7 +117,7 @@ class GuiDocMerge(QDialog):
         finalItems = []
         for i in range(self.listBox.count()):
             item = self.listBox.item(i)
-            if item.checkState() == Qt.Checked:
+            if item is not None and item.checkState() == Qt.Checked:
                 finalItems.append(item.data(Qt.UserRole))
 
         self._data["moveToTrash"] = self.trashSwitch.isChecked()

novelwriter/dialogs/docsplit.py

@@ -145,9 +145,12 @@ class GuiDocSplit(QDialog):
         headerList = []
         for i in range(self.listBox.count()):
             item = self.listBox.item(i)
-            headerList.append(
+            if item is not None:
-                (item.data(self.LINE_ROLE), item.data(self.LEVEL_ROLE), item.data(self.LABEL_ROLE))
+                headerList.append((
-            )
+                    item.data(self.LINE_ROLE),
+                    item.data(self.LEVEL_ROLE),
+                    item.data(self.LABEL_ROLE),
+                ))
 
         spLevel = self.splitLevel.currentData()
         intoFolder = self.folderSwitch.isChecked()

novelwriter/dialogs/projsettings.py

@@ -365,6 +365,7 @@ class GuiProjectEditStatus(QWidget):
             newList = []
             for n in range(self.listBox.topLevelItemCount()):
                 item = self.listBox.topLevelItem(n)
+                if item is not None:
                     newList.append({
                         "key":  item.data(self.COL_LABEL, self.KEY_ROLE),
                         "name": item.text(self.COL_LABEL),
@@ -468,6 +469,7 @@ class GuiProjectEditStatus(QWidget):
         self.listBox.insertTopLevelItem(nIndex, cItem)
         self.listBox.clearSelection()
 
+        if cItem is not None:
             cItem.setSelected(True)
         self.colChanged = True
 
@@ -617,6 +619,7 @@ class GuiProjectEditReplace(QWidget):
         newList = {}
         for n in range(self.listBox.topLevelItemCount()):
             tItem = self.listBox.topLevelItem(n)
+            if tItem is not None:
                 aKey = self._stripNotAllowed(tItem.text(0))
                 aVal = tItem.text(1)
                 if len(aKey) > 0:

novelwriter/dialogs/updates.py

@@ -135,7 +135,7 @@ class GuiUpdates(QDialog):
             logException()
 
         relVersion = rawData.get("tag_name", "Unknown")
-        relDate = rawData.get("created_at", None)
+        relDate = rawData.get("created_at", "")
 
         try:
             relDate = datetime.strptime(relDate[:10], "%Y-%m-%d").strftime("%x")

novelwriter/dialogs/wordlist.py

@@ -156,7 +156,9 @@ class GuiWordList(QDialog):
         try:
             with open(tmpFile, mode="w", encoding="utf-8") as outFile:
                 for i in range(self.listBox.count()):
-                    outFile.write(self.listBox.item(i).text() + "\n")
+                    item = self.listBox.item(i)
+                    if item is not None:
+                        outFile.write(item.text() + "\n")
 
         except Exception:
             logger.error("Could not save new word list")

novelwriter/gui/noveltree.py

@@ -508,6 +508,7 @@ class GuiNovelTree(QTreeWidget):
         self._actHandle = tHandle
         for i in range(self.topLevelItemCount()):
             tItem = self.topLevelItem(i)
+            if tItem is not None:
                 if tItem.data(self.C_TITLE, self.D_HANDLE) == tHandle:
                     tItem.setBackground(self.C_TITLE, self.palette().alternateBase())
                     tItem.setBackground(self.C_WORDS, self.palette().alternateBase())

novelwriter/gui/outline.py

@@ -675,6 +675,7 @@ class GuiOutlineTree(QTreeWidget):
             self.setColumnHidden(self._colIdx[nwOutline.TITLE], False)
 
             headItem = self.headerItem()
+            if headItem is not None:
                 headItem.setTextAlignment(self._colIdx[nwOutline.CCOUNT], Qt.AlignRight)
                 headItem.setTextAlignment(self._colIdx[nwOutline.WCOUNT], Qt.AlignRight)
                 headItem.setTextAlignment(self._colIdx[nwOutline.PCOUNT], Qt.AlignRight)

novelwriter/gui/projtree.py

@@ -1309,6 +1309,7 @@ class GuiProjectTree(QTreeWidget):
         self._postItemMove(sHandle, wCount)
         self._recordLastMove(sItem, pItem, pIndex)
         self._alertTreeChange(sHandle, flush=True)
+        if sItem is not None:
             sItem.setExpanded(isExpanded)
 
         return

novelwriter/tools/writingstats.py

@@ -112,6 +112,7 @@ class GuiWritingStats(QDialog):
         self.listBox.setColumnWidth(self.C_COUNT, wCol3)
 
         hHeader = self.listBox.headerItem()
+        if hHeader is not None:
             hHeader.setTextAlignment(self.C_LENGTH, Qt.AlignRight)
             hHeader.setTextAlignment(self.C_IDLE, Qt.AlignRight)
             hHeader.setTextAlignment(self.C_COUNT, Qt.AlignRight)