Add a bunch of None checks, even if many may be redundant

novelwriter/dialogs/docmerge.py

@@ -117,7 +117,7 @@ class GuiDocMerge(QDialog):
         finalItems = []
         for i in range(self.listBox.count()):
             item = self.listBox.item(i)
-            if item.checkState() == Qt.Checked:
+            if item is not None and item.checkState() == Qt.Checked:
                 finalItems.append(item.data(Qt.UserRole))
 
         self._data["moveToTrash"] = self.trashSwitch.isChecked()

novelwriter/dialogs/docsplit.py

@@ -145,9 +145,12 @@ class GuiDocSplit(QDialog):
         headerList = []
         for i in range(self.listBox.count()):
             item = self.listBox.item(i)
-            headerList.append(
-                (item.data(self.LINE_ROLE), item.data(self.LEVEL_ROLE), item.data(self.LABEL_ROLE))
-            )
+            if item is not None:
+                headerList.append((
+                    item.data(self.LINE_ROLE),
+                    item.data(self.LEVEL_ROLE),
+                    item.data(self.LABEL_ROLE),
+                ))
 
         spLevel = self.splitLevel.currentData()
         intoFolder = self.folderSwitch.isChecked()

novelwriter/dialogs/projsettings.py

@@ -365,11 +365,12 @@ class GuiProjectEditStatus(QWidget):
             newList = []
             for n in range(self.listBox.topLevelItemCount()):
                 item = self.listBox.topLevelItem(n)
-                newList.append({
-                    "key":  item.data(self.COL_LABEL, self.KEY_ROLE),
-                    "name": item.text(self.COL_LABEL),
-                    "cols": item.data(self.COL_LABEL, self.COL_ROLE),
-                })
+                if item is not None:
+                    newList.append({
+                        "key":  item.data(self.COL_LABEL, self.KEY_ROLE),
+                        "name": item.text(self.COL_LABEL),
+                        "cols": item.data(self.COL_LABEL, self.COL_ROLE),
+                    })
             return newList, self.colDeleted
 
         return [], []
@@ -468,7 +469,8 @@ class GuiProjectEditStatus(QWidget):
         self.listBox.insertTopLevelItem(nIndex, cItem)
         self.listBox.clearSelection()
 
-        cItem.setSelected(True)
+        if cItem is not None:
+            cItem.setSelected(True)
         self.colChanged = True
 
         return
@@ -617,10 +619,11 @@ class GuiProjectEditReplace(QWidget):
         newList = {}
         for n in range(self.listBox.topLevelItemCount()):
             tItem = self.listBox.topLevelItem(n)
-            aKey = self._stripNotAllowed(tItem.text(0))
-            aVal = tItem.text(1)
-            if len(aKey) > 0:
-                newList[aKey] = aVal
+            if tItem is not None:
+                aKey = self._stripNotAllowed(tItem.text(0))
+                aVal = tItem.text(1)
+                if len(aKey) > 0:
+                    newList[aKey] = aVal
 
         return newList
 

novelwriter/dialogs/updates.py

@@ -135,7 +135,7 @@ class GuiUpdates(QDialog):
             logException()
 
         relVersion = rawData.get("tag_name", "Unknown")
-        relDate = rawData.get("created_at", None)
+        relDate = rawData.get("created_at", "")
 
         try:
             relDate = datetime.strptime(relDate[:10], "%Y-%m-%d").strftime("%x")

novelwriter/dialogs/wordlist.py

@@ -156,7 +156,9 @@ class GuiWordList(QDialog):
         try:
             with open(tmpFile, mode="w", encoding="utf-8") as outFile:
                 for i in range(self.listBox.count()):
-                    outFile.write(self.listBox.item(i).text() + "\n")
+                    item = self.listBox.item(i)
+                    if item is not None:
+                        outFile.write(item.text() + "\n")
 
         except Exception:
             logger.error("Could not save new word list")