Reproog/novelWriter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix footnote navigation in viewer

Browse Source
This commit is contained in:
Veronica Berglyd Olsen
2024-06-02 23:36:28 +02:00
parent 92b7168363
commit 7744ae5912
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
novelwriter/gui/docviewer.py
+3 -1
View File
@@ -364,8 +364,10 @@ class GuiDocViewer(QTextBrowser):
"""Process a clicked link in the document.""" """Process a clicked link in the document."""
if link := url.url(): if link := url.url():
logger.debug("Clicked link: '%s'", link) logger.debug("Clicked link: '%s'", link)
if (bits := link.partition("_")) and bits[2]: if (bits := link.partition("_")) and bits[0] == "#tag" and bits[2]:
self.loadDocumentTagRequest.emit(bits[2], nwDocMode.VIEW) self.loadDocumentTagRequest.emit(bits[2], nwDocMode.VIEW)
else:
self.navigateTo(link)
return return
@pyqtSlot("QPoint") @pyqtSlot("QPoint")
tests/test_gui/test_gui_docviewer.py
+5
View File
@@ -160,6 +160,11 @@ def testGuiViewer_Main(qtbot, monkeypatch, nwGUI, prjLipsum):
docViewer._linkClicked(QUrl("#tag_bod")) docViewer._linkClicked(QUrl("#tag_bod"))
assert docViewer.docHandle == "4c4f28287af27" assert docViewer.docHandle == "4c4f28287af27"
# Other links should just trigger a navigate call
with qtbot.waitSignal(docViewer.sourceChanged, timeout=1000) as signal:
docViewer._linkClicked(QUrl("#somewhere_else"))
assert signal.args[0].url() == "#somewhere_else"
# Click mouse nav buttons # Click mouse nav buttons
qtbot.mouseClick(docViewer.viewport(), Qt.BackButton, pos=rect.center(), delay=100) qtbot.mouseClick(docViewer.viewport(), Qt.BackButton, pos=rect.center(), delay=100)
assert docViewer.docHandle == "88243afbe5ed8" assert docViewer.docHandle == "88243afbe5ed8"