Update tests

tests/test_dialogs/test_dlg_itemeditor.py

@@ -20,7 +20,6 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
 """
 
 import pytest
-import random
 
 from tools import getGuiItem
 
@@ -31,9 +30,12 @@ from novelwriter.enum import nwItemLayout, nwItemType
 from novelwriter.dialogs import GuiItemEditor
 from novelwriter.core.tree import NWTree
 
+statusKeys = ["s000000", "s000001", "s000002", "s000003"]
+importKeys = ["i000004", "i000005", "i000006", "i000007"]
+
 
 @pytest.mark.gui
-def testDlgItemEditor_Dialog(qtbot, monkeypatch, nwGUI, fncProj):
+def testDlgItemEditor_Dialog(qtbot, monkeypatch, nwGUI, fncProj, mockRnd):
     """Test launching the item editor dialog from GuiMain.
     """
     # Block message box
@@ -46,15 +48,15 @@ def testDlgItemEditor_Dialog(qtbot, monkeypatch, nwGUI, fncProj):
     assert nwGUI.editItem() is False
 
     # Create and Open Project
-    nwGUI.theProject.projTree.setSeed(42)
     assert nwGUI.newProject({"projPath": fncProj})
+    tHandle = "000000000000f"
 
     # No Selection
     nwGUI.treeView.clearSelection()
     assert nwGUI.editItem() is False
 
     # Force opening from editor
-    assert nwGUI.openDocument("0e17daca5f3e1")
+    assert nwGUI.openDocument(tHandle)
     nwGUI.isFocusMode = True
 
     # Block Tree Lookup
@@ -63,9 +65,9 @@ def testDlgItemEditor_Dialog(qtbot, monkeypatch, nwGUI, fncProj):
         assert nwGUI.editItem() is False
 
     # Invalid Type
-    nwGUI.theProject.projTree["0e17daca5f3e1"]._type = nwItemType.NO_TYPE
+    nwGUI.theProject.projTree[tHandle]._type = nwItemType.NO_TYPE
     assert nwGUI.editItem() is False
-    nwGUI.theProject.projTree["0e17daca5f3e1"]._type = nwItemType.FILE
+    nwGUI.theProject.projTree[tHandle]._type = nwItemType.FILE
 
     # Open Properly
     assert nwGUI.editItem() is True
@@ -89,7 +91,7 @@ def testDlgItemEditor_Dialog(qtbot, monkeypatch, nwGUI, fncProj):
 
 
 @pytest.mark.gui
-def testDlgItemEditor_Novel(qtbot, monkeypatch, nwGUI, fncProj, constData):
+def testDlgItemEditor_Novel(qtbot, monkeypatch, nwGUI, fncProj, mockRnd):
     """Test the item editor dialog for a novel document.
     """
     # Block message box
@@ -97,13 +99,13 @@ def testDlgItemEditor_Novel(qtbot, monkeypatch, nwGUI, fncProj, constData):
     monkeypatch.setattr(GuiProjectTree, "hasFocus", lambda *a: True)
 
     # Create Project and Open Document
-    random.seed(42)
-    nwGUI.theProject.projTree.setSeed(42)
     assert nwGUI.newProject({"projPath": fncProj})
-    assert nwGUI.theProject.statusItems.name(constData.statusKeys[0]) == "New"
-    assert nwGUI.theProject.statusItems.name(constData.statusKeys[1]) == "Note"
+    tHandle = "000000000000f"
 
-    assert nwGUI.openDocument("0e17daca5f3e1") is True
+    assert nwGUI.theProject.statusItems.name(statusKeys[0]) == "New"
+    assert nwGUI.theProject.statusItems.name(statusKeys[1]) == "Note"
+
+    assert nwGUI.openDocument(tHandle) is True
 
     # Check that an invalid handle is managed
     itemEdit = GuiItemEditor(nwGUI, "whatever")
@@ -111,12 +113,12 @@ def testDlgItemEditor_Novel(qtbot, monkeypatch, nwGUI, fncProj, constData):
     itemEdit._doClose()
 
     # Edit a Document
-    itemEdit = GuiItemEditor(nwGUI, "0e17daca5f3e1")
+    itemEdit = GuiItemEditor(nwGUI, tHandle)
     itemEdit.show()
 
     # Check Existing Settings
     assert itemEdit.editName.text() == "New Scene"
-    assert itemEdit.editStatus.currentData() == constData.statusKeys[0]
+    assert itemEdit.editStatus.currentData() == statusKeys[0]
     assert itemEdit.editLayout.currentData() == nwItemLayout.DOCUMENT
     assert itemEdit.editExport.isChecked() is True
 
@@ -130,12 +132,12 @@ def testDlgItemEditor_Novel(qtbot, monkeypatch, nwGUI, fncProj, constData):
     # Check New Settings
     itemEdit._doSave()
     assert itemEdit.theItem.itemName == "Great Scene"
-    assert itemEdit.theItem.itemStatus == constData.statusKeys[1]
+    assert itemEdit.theItem.itemStatus == statusKeys[1]
     assert itemEdit.theItem.itemLayout == nwItemLayout.NOTE
     assert itemEdit.theItem.isExported is False
 
     # Check that the editor header is updated
-    nwGUI.docEditor.updateDocInfo("0e17daca5f3e1")
+    nwGUI.docEditor.updateDocInfo(tHandle)
     assert nwGUI.docEditor.docHeader.theTitle.text() == "Novel  ›  New Chapter  ›  Great Scene"
 
     itemEdit.close()
@@ -146,7 +148,7 @@ def testDlgItemEditor_Novel(qtbot, monkeypatch, nwGUI, fncProj, constData):
 
 
 @pytest.mark.gui
-def testDlgItemEditor_Note(qtbot, monkeypatch, nwGUI, fncProj, constData):
+def testDlgItemEditor_Note(qtbot, monkeypatch, nwGUI, fncProj, mockRnd):
     """Test the item editor dialog for a project note.
     """
     # Block message box
@@ -154,29 +156,27 @@ def testDlgItemEditor_Note(qtbot, monkeypatch, nwGUI, fncProj, constData):
     monkeypatch.setattr(GuiProjectTree, "hasFocus", lambda *a: True)
 
     # Create Project and Open Document
-    random.seed(42)
-    nwGUI.theProject.projTree.setSeed(42)
     assert nwGUI.newProject({"projPath": fncProj})
-    assert nwGUI.theProject.statusItems.name(constData.statusKeys[0]) == "New"
-    assert nwGUI.theProject.statusItems.name(constData.statusKeys[1]) == "Note"
-    assert nwGUI.theProject.importItems.name(constData.importKeys[0]) == "New"
-    assert nwGUI.theProject.importItems.name(constData.importKeys[1]) == "Minor"
+    assert nwGUI.theProject.statusItems.name(statusKeys[0]) == "New"
+    assert nwGUI.theProject.statusItems.name(statusKeys[1]) == "Note"
+    assert nwGUI.theProject.importItems.name(importKeys[0]) == "New"
+    assert nwGUI.theProject.importItems.name(importKeys[1]) == "Minor"
 
     # Create Note
     nwGUI.treeView.clearSelection()
-    nwGUI.treeView._getTreeItem("71ee45a3c0db9").setSelected(True)
+    nwGUI.treeView._getTreeItem("000000000000a").setSelected(True)
     nwGUI.treeView.newTreeItem(nwItemType.FILE, None)
 
     # Open Note
-    assert nwGUI.openDocument("1a6562590ef19")
+    assert nwGUI.openDocument("0000000000010")
 
     # Edit a Document
-    itemEdit = GuiItemEditor(nwGUI, "1a6562590ef19")
+    itemEdit = GuiItemEditor(nwGUI, "0000000000010")
     itemEdit.show()
 
     # Check Existing Settings
     assert itemEdit.editName.text() == "New Note"
-    assert itemEdit.editStatus.currentData() == constData.importKeys[0]
+    assert itemEdit.editStatus.currentData() == importKeys[0]
     assert itemEdit.editLayout.currentData() == nwItemLayout.NOTE
     assert itemEdit.editExport.isChecked() is True
 
@@ -188,8 +188,8 @@ def testDlgItemEditor_Note(qtbot, monkeypatch, nwGUI, fncProj, constData):
 
     # Check New Settings
     assert itemEdit.theItem.itemName == "New Character"
-    assert itemEdit.theItem.itemStatus == constData.statusKeys[0]
-    assert itemEdit.theItem.itemImport == constData.importKeys[1]
+    assert itemEdit.theItem.itemStatus == statusKeys[0]
+    assert itemEdit.theItem.itemImport == importKeys[1]
     assert itemEdit.theItem.itemLayout == nwItemLayout.NOTE
     assert itemEdit.theItem.isExported is False
 
@@ -201,7 +201,7 @@ def testDlgItemEditor_Note(qtbot, monkeypatch, nwGUI, fncProj, constData):
 
 
 @pytest.mark.gui
-def testDlgItemEditor_Folder(qtbot, monkeypatch, nwGUI, fncProj, constData):
+def testDlgItemEditor_Folder(qtbot, monkeypatch, nwGUI, fncProj, mockRnd):
     """Test the item editor dialog for a folder.
     """
     # Block message box
@@ -209,20 +209,18 @@ def testDlgItemEditor_Folder(qtbot, monkeypatch, nwGUI, fncProj, constData):
     monkeypatch.setattr(GuiProjectTree, "hasFocus", lambda *a: True)
 
     # Create Project and Open Document
-    random.seed(42)
-    nwGUI.theProject.projTree.setSeed(42)
     assert nwGUI.newProject({"projPath": fncProj})
 
     # Edit a Folder
-    itemEdit = GuiItemEditor(nwGUI, "31489056e0916")
+    itemEdit = GuiItemEditor(nwGUI, "000000000000d")
     itemEdit.show()
 
-    assert nwGUI.theProject.statusItems.name(constData.statusKeys[0]) == "New"
-    assert nwGUI.theProject.statusItems.name(constData.statusKeys[1]) == "Note"
+    assert nwGUI.theProject.statusItems.name(statusKeys[0]) == "New"
+    assert nwGUI.theProject.statusItems.name(statusKeys[1]) == "Note"
 
     # Check Existing Settings
     assert itemEdit.editName.text() == "New Chapter"
-    assert itemEdit.editStatus.currentData() == constData.statusKeys[0]
+    assert itemEdit.editStatus.currentData() == statusKeys[0]
     assert itemEdit.editLayout.currentData() == nwItemLayout.NO_LAYOUT
     assert itemEdit.editExport.isChecked() is False
 
@@ -236,7 +234,7 @@ def testDlgItemEditor_Folder(qtbot, monkeypatch, nwGUI, fncProj, constData):
     # Check New Settings
     itemEdit._doSave()
     assert itemEdit.theItem.itemName == "Chapter One"
-    assert itemEdit.theItem.itemStatus == constData.statusKeys[1]
+    assert itemEdit.theItem.itemStatus == statusKeys[1]
     assert itemEdit.theItem.itemLayout == nwItemLayout.NO_LAYOUT
     assert itemEdit.theItem.isExported is False