Make sure the document isn't overwritten if it exists, but we have an error loading it due to encoding, or otherwise

2019-10-28 14:12:26 +01:00
parent f760eeb544
commit 4fcff94b05
3 changed files with 25 additions and 6 deletions
@@ -57,8 +57,13 @@ class NWDoc():
                    theDoc = inFile.read()
            except Exception as e:
                self.makeAlert(["Failed to open document file.",str(e)], nwAlert.ERROR)
-                return ""
+                # Note: Document must be cleared in case of an io error, or else the auto-save or
+                # save will try to overwrite it with an empty file. Return None to alert the caller.
+                self.clearDocument()
+                return None
        else:
+            # The document file does not exist, so we assume it's a new document and initialise an
+            # empty text string.
            logger.debug("The requested document does not exist.")
            return ""