Remove deleteLater calls that can be replaced by setParent(None)

novelwriter/gui/docviewer.py

@@ -424,7 +424,8 @@ class GuiDocViewer(QTextBrowser):
         # Open the context menu
         if viewport := self.viewport():
             ctxMenu.exec(viewport.mapToGlobal(point))
-            ctxMenu.deleteLater()
+
+        ctxMenu.setParent(None)
 
         return
 

novelwriter/gui/projtree.py

@@ -969,7 +969,8 @@ class GuiProjectTree(QTreeView):
 
                 if viewport := self.viewport():
                     ctxMenu.exec(viewport.mapToGlobal(point))
-                    ctxMenu.deleteLater()
+
+                ctxMenu.setParent(None)
 
         return
 

novelwriter/guimain.py

@@ -1064,7 +1064,7 @@ class GuiMain(QMainWindow):
 
         if syntax:
             SHARED.theme.loadSyntax()
-            self.docEditor.updateSyntaxColours()
+            self.docEditor.updateSyntaxColors()
 
         self.docEditor.initEditor()
         self.docViewer.initViewer()

novelwriter/tools/welcome.py

@@ -366,7 +366,7 @@ class _OpenProjectPage(QWidget):
         action = qtAddAction(ctxMenu, self.tr("Remove Project"))
         action.triggered.connect(self._deleteSelectedItem)
         ctxMenu.exec(self.mapToGlobal(pos))
-        ctxMenu.deleteLater()
+        ctxMenu.setParent(None)
         return
 
     ##

tests/test_gui/test_gui_doceditor.py

@@ -333,6 +333,7 @@ def testGuiEditor_MetaData(qtbot, nwGUI, projPath, mockRnd):
 def testGuiEditor_ContextMenu(monkeypatch, qtbot, nwGUI, projPath, mockRnd):
     """Test the editor context menu."""
     monkeypatch.setattr(QMenu, "exec", lambda *a: None)
+    monkeypatch.setattr(QMenu, "setParent", lambda *a: None)
 
     buildTestProject(nwGUI, projPath)
     assert nwGUI.openDocument(C.hSceneDoc) is True
@@ -475,6 +476,7 @@ def testGuiEditor_ContextMenu(monkeypatch, qtbot, nwGUI, projPath, mockRnd):
 def testGuiEditor_SpellChecking(qtbot, monkeypatch, nwGUI, projPath, ipsumText, mockRnd):
     """Test the document spell checker."""
     monkeypatch.setattr(QMenu, "exec", lambda *a: None)
+    monkeypatch.setattr(QMenu, "setParent", lambda *a: None)
 
     buildTestProject(nwGUI, projPath)
     assert nwGUI.openDocument(C.hSceneDoc) is True

tests/test_tools/test_tools_welcome.py

@@ -70,6 +70,7 @@ def testToolWelcome_Main(qtbot, monkeypatch, nwGUI, fncPath):
 def testToolWelcome_Open(qtbot, monkeypatch, nwGUI, fncPath):
     """Test the open tab in the Welcome window."""
     monkeypatch.setattr(QMenu, "exec", lambda *a: None)
+    monkeypatch.setattr(QMenu, "setParent", lambda *a: None)
 
     CONFIG.recentProjects.update("/stuff/project_one", "Project One", 12345, 1690000000)
     CONFIG.recentProjects.update("/stuff/project_two", "Project Two", 54321, 1700000000)