Reproog/novelWriter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable hidden tab feature for older Qt libs

Browse Source
This commit is contained in:
Veronica Berglyd Olsen
2023-11-18 21:04:35 +01:00
parent 2fca22359b
commit 40c07973ce
3 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
novelwriter/gui/docviewerpanel.py
+3 -2
View File
@@ -164,8 +164,9 @@ class GuiDocViewerPanel(QWidget):
def _updateTabVisibility(self) -> None: def _updateTabVisibility(self) -> None:
"""Hide class tabs with no content.""" """Hide class tabs with no content."""
for tClass, cTab in self.kwTabs.items(): if CONFIG.verQtValue >= 0x050f00:
self.mainTabs.setTabVisible(self.idTabs[tClass], cTab.countEntries() > 0) for tClass, cTab in self.kwTabs.items():
self.mainTabs.setTabVisible(self.idTabs[tClass], cTab.countEntries() > 0)
return return
# END Class GuiDocViewerPanel # END Class GuiDocViewerPanel
tests/requirements.txt
+1 -1
View File
@@ -1,4 +1,4 @@
pytest>=4.0.0 pytest>=6.0.0
pytest-timeout pytest-timeout
pytest-cov pytest-cov
pytest-qt pytest-qt
tests/test_gui/test_gui_docviewerpanel.py
+9 -8
View File
@@ -23,7 +23,7 @@ import pytest
from tools import C, buildTestProject from tools import C, buildTestProject
from novelwriter import SHARED from novelwriter import CONFIG, SHARED
from novelwriter.constants import nwLists from novelwriter.constants import nwLists
from novelwriter.dialogs.editlabel import GuiEditLabel from novelwriter.dialogs.editlabel import GuiEditLabel
@@ -134,13 +134,14 @@ def testGuiViewerPanel_Tags(qtbot, monkeypatch, caplog, nwGUI, projPath, mockRnd
nwGUI.docEditor._processTag(cursor, create=True) nwGUI.docEditor._processTag(cursor, create=True)
# Check Panel Tab Visibility # Check Panel Tab Visibility
assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["CHARACTER"]) is True if CONFIG.verQtValue >= 0x050f00:
assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["PLOT"]) is False assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["CHARACTER"]) is True
assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["WORLD"]) is False assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["PLOT"]) is False
assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["TIMELINE"]) is False assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["WORLD"]) is False
assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["OBJECT"]) is False assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["TIMELINE"]) is False
assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["ENTITY"]) is False assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["OBJECT"]) is False
assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["CUSTOM"]) is False assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["ENTITY"]) is False
assert viewPanel.mainTabs.isTabVisible(viewPanel.idTabs["CUSTOM"]) is False
# Check Character Tab # Check Character Tab
charTab = viewPanel.kwTabs["CHARACTER"] charTab = viewPanel.kwTabs["CHARACTER"]