Make icon theme a part of the GUI theme (solves #1172)

tests/test_base/test_base_config.py

@@ -192,32 +192,6 @@ def testBaseConfig_Init(monkeypatch, tmpDir, fncDir, outDir, refDir, filesDir):
     tstConf.doReplaceSQuote = orDoSng
     assert tstConf.saveConfig() is True
 
-    # Test Correcting icon theme
-    origIcons = tstConf.guiIcons
-
-    tstConf.guiIcons = "typicons_colour_dark"
-    assert tstConf.saveConfig() is True
-    assert tstConf.loadConfig() is True
-    assert tstConf.guiIcons == "typicons_dark"
-
-    tstConf.guiIcons = "typicons_grey_dark"
-    assert tstConf.saveConfig() is True
-    assert tstConf.loadConfig() is True
-    assert tstConf.guiIcons == "typicons_dark"
-
-    tstConf.guiIcons = "typicons_colour_light"
-    assert tstConf.saveConfig() is True
-    assert tstConf.loadConfig() is True
-    assert tstConf.guiIcons == "typicons_light"
-
-    tstConf.guiIcons = "typicons_grey_light"
-    assert tstConf.saveConfig() is True
-    assert tstConf.loadConfig() is True
-    assert tstConf.guiIcons == "typicons_light"
-
-    tstConf.guiIcons = origIcons
-    assert tstConf.saveConfig()
-
     # Localisation
     # ============
 

tests/test_gui/test_gui_theme.py

@@ -50,7 +50,7 @@ def testGuiTheme_Main(qtbot, monkeypatch, nwMinimal, tmpDir):
     assert novelwriter.CONFIG.confPath == nwMinimal
     novelwriter.CONFIG.guiTheme = "default_dark"
     novelwriter.CONFIG.guiSyntax = "tomorrow_night_eighties"
-    novelwriter.CONFIG.guiIcons = "typicons_colour_dark"
+    novelwriter.CONFIG.guiIcons = "typicons_dark"
     novelwriter.CONFIG.guiFont = "Cantarell"
     novelwriter.CONFIG.guiFontSize = 11
     novelwriter.CONFIG.confChanged = True