Fix and optimise code (#904)

* Fix bug in early error reporting in main init
* Update docstrings and optimise code in GuiMain
* Update docstrings and optimise code in Config
* Update docstrings and optimise code in common module
* Update docstrings and optimise code in main project classes
* Update the OptionState class
* Update the spell checker class
* Update the file converter classes and extend tests
* Update the about, merge, split and item editor classes and extend tests
* Update item editor test
* Update about dialog tests
* Some minor test cleanup
* Fix typo and add clarification in contributing guide

tests/test_dialogs/test_dlg_about.py

@@ -27,23 +27,22 @@ from PyQt5.QtWidgets import QAction, QMessageBox
 
 from novelwriter.dialogs import GuiAbout
 
-keyDelay = 2
-typeDelay = 1
-stepDelay = 20
-
 
 @pytest.mark.gui
-def testDlgAbout_Dialog(qtbot, monkeypatch, nwGUI):
-    """Test the full about dialogs.
+def testDlgAbout_NWDialog(qtbot, monkeypatch, nwGUI):
+    """Test the novelWriter about dialogs.
     """
-    # NW About
-    monkeypatch.setattr(GuiAbout, "exec_", lambda *a: None)
-    nwGUI.mainMenu.aAboutNW.activate(QAction.Trigger)
-    qtbot.waitUntil(lambda: getGuiItem("GuiAbout") is not None, timeout=1000)
+    # Block message box
+    monkeypatch.setattr(QMessageBox, "question", lambda *a: QMessageBox.Yes)
 
+    # NW About
+    nwGUI.theTheme.themeName = "A Theme"
+    nwGUI.theTheme.themeAuthor = "An Author"
+    assert nwGUI.showAboutNWDialog(showNotes=True) is True
+
+    qtbot.waitUntil(lambda: getGuiItem("GuiAbout") is not None, timeout=1000)
     msgAbout = getGuiItem("GuiAbout")
     assert isinstance(msgAbout, GuiAbout)
-    msgAbout.show()
 
     assert msgAbout.pageAbout.document().characterCount() > 100
     assert msgAbout.pageNotes.document().characterCount() > 100
@@ -59,12 +58,29 @@ def testDlgAbout_Dialog(qtbot, monkeypatch, nwGUI):
 
     msgAbout.showReleaseNotes()
     assert msgAbout.tabBox.currentWidget() == msgAbout.pageNotes
-
-    # Qt About
-    monkeypatch.setattr(QMessageBox, "aboutQt", lambda *a, **k: None)
-    nwGUI.mainMenu.aAboutQt.activate(QAction.Trigger)
-
-    # qtbot.stopForInteraction()
     msgAbout._doClose()
 
-# END Test testDlgAbout_Dialog
+    # Open Again from Menu
+    nwGUI.mainMenu.aAboutNW.activate(QAction.Trigger)
+    qtbot.waitUntil(lambda: getGuiItem("GuiAbout") is not None, timeout=1000)
+    msgAbout = getGuiItem("GuiAbout")
+    assert msgAbout is not None
+    msgAbout._doClose()
+
+# END Test testDlgAbout_NWDialog
+
+
+@pytest.mark.gui
+def testDlgAbout_QtDialog(monkeypatch, nwGUI):
+    """Test the Qt about dialogs.
+    """
+    # Block message box
+    monkeypatch.setattr(QMessageBox, "question", lambda *a: QMessageBox.Yes)
+    monkeypatch.setattr(QMessageBox, "aboutQt", lambda *a, **k: None)
+
+    # Open About
+    # All it can do is check aigainst a crash
+    assert nwGUI.showAboutQtDialog() is True
+    nwGUI.mainMenu.aAboutQt.activate(QAction.Trigger)
+
+# END Test testDlgAbout_QtDialog