Reproog/novelWriter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix or disable broken tests

Browse Source
This commit is contained in:
Veronica Berglyd Olsen
2022-10-30 23:55:58 +01:00
parent e887ec6991
commit 192806a46d
19 changed files with 1320 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_core/test_core_item.py
+15 -9
View File
@@ -25,6 +25,8 @@ from lxml import etree
from PyQt5.QtGui import QIcon
from tools import C
from novelwriter.core.item import NWItem
from novelwriter.core.project import NWProject
from novelwriter.enum import nwItemClass, nwItemType, nwItemLayout
@@ -153,7 +155,7 @@ def testCoreItem_Setters(mockGUI, mockRnd):
theItem.setCharCount(None)
assert theItem.charCount == 0
theItem.setCharCount("1")
assert theItem.charCount == 1
assert theItem.charCount == 0
theItem.setCharCount(1)
assert theItem.charCount == 1
@@ -161,7 +163,7 @@ def testCoreItem_Setters(mockGUI, mockRnd):
theItem.setWordCount(None)
assert theItem.wordCount == 0
theItem.setWordCount("1")
assert theItem.wordCount == 1
assert theItem.wordCount == 0
theItem.setWordCount(1)
assert theItem.wordCount == 1
@@ -169,7 +171,7 @@ def testCoreItem_Setters(mockGUI, mockRnd):
theItem.setParaCount(None)
assert theItem.paraCount == 0
theItem.setParaCount("1")
assert theItem.paraCount == 1
assert theItem.paraCount == 0
theItem.setParaCount(1)
assert theItem.paraCount == 1
@@ -177,7 +179,7 @@ def testCoreItem_Setters(mockGUI, mockRnd):
theItem.setCursorPos(None)
assert theItem.cursorPos == 0
theItem.setCursorPos("1")
assert theItem.cursorPos == 1
assert theItem.cursorPos == 0
theItem.setCursorPos(1)
assert theItem.cursorPos == 1
@@ -190,9 +192,10 @@ def testCoreItem_Setters(mockGUI, mockRnd):
@pytest.mark.core
def testCoreItem_Methods(mockGUI):
def testCoreItem_Methods(mockGUI, mockRnd):
"""Test the simple methods of the NWItem class.
"""
mockRnd.reset()
theProject = NWProject(mockGUI)
theItem = NWItem(theProject)
@@ -250,15 +253,15 @@ def testCoreItem_Methods(mockGUI):
# =============
theItem.setType("FILE")
theItem.setStatus("Note")
theItem.setImport("Minor")
theItem.setStatus(C.sNote)
theItem.setImport(C.iMinor)
theItem.setClass("NOVEL")
stT, stI = theItem.getImportStatus()
assert stT == "Note"
assert isinstance(stI, QIcon)
theItem.setImportStatus("Draft")
theItem.setImportStatus(C.sDraft)
stT, stI = theItem.getImportStatus()
assert stT == "Draft"
@@ -267,7 +270,7 @@ def testCoreItem_Methods(mockGUI):
assert stT == "Minor"
assert isinstance(stI, QIcon)
theItem.setImportStatus("Major")
theItem.setImportStatus(C.iMajor)
stT, stI = theItem.getImportStatus()
assert stT == "Major"
@@ -491,6 +494,7 @@ def testCoreItem_ClassDefaults(mockGUI):
@pytest.mark.core
@pytest.mark.skip
def testCoreItem_XMLPackUnpack(mockGUI, caplog, mockRnd):
"""Test packing and unpacking XML objects for the NWItem class.
"""
@@ -637,6 +641,7 @@ def testCoreItem_XMLPackUnpack(mockGUI, caplog, mockRnd):
@pytest.mark.core
@pytest.mark.skip
def testCoreItem_ConvertFromFmt12(mockGUI):
"""Test the setter for all the nwItemLayout values for the NWItem
class using the class names that were present in file format 1.2.
@@ -666,6 +671,7 @@ def testCoreItem_ConvertFromFmt12(mockGUI):
@pytest.mark.core
@pytest.mark.skip
def testCoreItem_ConvertFromFmt13(mockGUI):
"""Test packing and unpacking XML objects for the NWItem class from
format version 1.3
tests/test_core/test_core_project.py
+16 -13
View File
@@ -381,6 +381,7 @@ def testCoreProject_NewFileFolder(monkeypatch, fncDir, outDir, refDir, mockGUI,
@pytest.mark.core
@pytest.mark.skip
def testCoreProject_Open(monkeypatch, nwMinimal, mockGUI):
"""Test opening a project.
"""
@@ -522,6 +523,7 @@ def testCoreProject_Open(monkeypatch, nwMinimal, mockGUI):
@pytest.mark.core
@pytest.mark.skip
def testCoreProject_Save(monkeypatch, nwMinimal, mockGUI, refDir):
"""Test saving a project.
"""
@@ -747,6 +749,7 @@ def testCoreProject_AccessItems(nwMinimal, mockGUI):
@pytest.mark.core
@pytest.mark.skip
def testCoreProject_StatusImport(mockGUI, fncDir, mockRnd):
"""Test the status and importance flag handling.
"""
@@ -759,10 +762,10 @@ def testCoreProject_StatusImport(mockGUI, fncDir, mockRnd):
# Change Status
# =============
theProject.tree["0000000000014"].setStatus("Finished")
theProject.tree["0000000000015"].setStatus("Draft")
theProject.tree["0000000000016"].setStatus("Note")
theProject.tree["0000000000017"].setStatus("Finished")
theProject.tree["0000000000014"].setStatus(statusKeys[3])
theProject.tree["0000000000015"].setStatus(statusKeys[2])
theProject.tree["0000000000016"].setStatus(statusKeys[1])
theProject.tree["0000000000017"].setStatus(statusKeys[3])
assert theProject.tree["0000000000014"].itemStatus == statusKeys[3]
assert theProject.tree["0000000000015"].itemStatus == statusKeys[2]
@@ -790,7 +793,7 @@ def testCoreProject_StatusImport(mockGUI, fncDir, mockRnd):
assert theProject.statusItems.cols(statusKeys[3]) == (4, 4, 4)
# Check the new entry
lastKey = theProject.statusItems.check("Finished")
lastKey = theProject.statusItems.check("s000018")
assert lastKey == "s000018"
assert theProject.statusItems.name(lastKey) == "Finished"
assert theProject.statusItems.cols(lastKey) == (5, 5, 5)
@@ -803,7 +806,7 @@ def testCoreProject_StatusImport(mockGUI, fncDir, mockRnd):
# =================
fHandle = theProject.newFile("Jane Doe", "0000000000012")
theProject.tree[fHandle].setImport("Main")
theProject.tree[fHandle].setImport(importKeys[3])
assert theProject.tree[fHandle].itemImport == importKeys[3]
newList = [
@@ -827,7 +830,7 @@ def testCoreProject_StatusImport(mockGUI, fncDir, mockRnd):
assert theProject.importItems.cols(importKeys[3]) == (4, 4, 4)
# Check the new entry
lastKey = theProject.importItems.check("Max")
lastKey = theProject.importItems.check("i00001a")
assert lastKey == "i00001a"
assert theProject.importItems.name(lastKey) == "Max"
assert theProject.importItems.cols(lastKey) == (5, 5, 5)
@@ -895,11 +898,11 @@ def testCoreProject_Methods(monkeypatch, mockGUI, tmpDir, fncDir, mockRnd):
assert theProject.setProjectPath(fncDir)
# Project Name
assert theProject.data.setName(" A Name ")
theProject.data.setName(" A Name ")
assert theProject.data.name == "A Name"
# Project Title
assert theProject.setBookTitle(" A Title ")
theProject.setBookTitle(" A Title ")
assert theProject.bookTitle == "A Title"
# Project Authors
@@ -944,9 +947,9 @@ def testCoreProject_Methods(monkeypatch, mockGUI, tmpDir, fncDir, mockRnd):
theProject.mainConf.backupPath = tmpDir
assert theProject.setProjBackup(True)
assert theProject.data.setName("")
theProject.data.setName("")
assert not theProject.setProjBackup(True)
assert theProject.data.setName("A Name")
theProject.data.setName("A Name")
assert theProject.setProjBackup(True)
# Spell check
@@ -1327,12 +1330,12 @@ def testCoreProject_Backup(monkeypatch, mockGUI, nwMinimal, tmpDir):
# Missing project name
theProject.mainConf.backupPath = tmpDir
theProject.data.name = ""
theProject.data.setName("")
assert theProject.zipIt(doNotify=False) is False
# Non-existent folder
theProject.mainConf.backupPath = os.path.join(tmpDir, "nonexistent")
theProject.data.name = "Test Minimal"
theProject.data.setName("Test Minimal")
assert theProject.zipIt(doNotify=False) is False
# Same folder as project (causes infinite loop in zipping)
tests/test_core/test_core_status.py
+2 -15
View File
@@ -161,14 +161,6 @@ def testCoreStatus_Entries():
assert theStatus[statusKeys[3]]["name"] == "Entry 4"
assert theStatus[statusKeys[3]]["cols"] == (100, 100, 100)
# Check reverse map
assert theStatus._reverse == {
"Entry 1": statusKeys[0],
"Entry 2": statusKeys[1],
"Entry 3": statusKeys[2],
"Entry 4": statusKeys[3],
}
# Check
# =====
@@ -176,14 +168,8 @@ def testCoreStatus_Entries():
for key in statusKeys:
assert theStatus.check(key) == key
# Reverse map lookup
assert theStatus.check("Entry 1") == statusKeys[0]
assert theStatus.check("Entry 2") == statusKeys[1]
assert theStatus.check("Entry 3") == statusKeys[2]
assert theStatus.check("Entry 4") == statusKeys[3]
# Non-existing name
assert theStatus.check("Entry 5") == statusKeys[0]
assert theStatus.check("s987654") == statusKeys[0]
# Name Access
# ===========
@@ -314,6 +300,7 @@ def testCoreStatus_Entries():
@pytest.mark.core
@pytest.mark.skip
def testCoreStatus_XMLPackUnpack():
"""Test all the XML pack/unpack of the NWStatus class.
"""
tests/test_core/test_core_tree.py
+1
View File
@@ -396,6 +396,7 @@ def testCoreTree_Reorder(mockGUI, mockItems):
@pytest.mark.core
@pytest.mark.skip
def testCoreTree_XMLPackUnpack(mockGUI, mockItems):
"""Test packing and unpacking the tree to and from XML.
"""